Re: [Lse-tech] Re: (RFC): SKB Initialization

From: David S. Miller (davem@redhat.com)
Date: Fri Aug 23 2002 - 17:41:14 EST


   From: Dave Hansen <haveblue@us.ibm.com>
   Date: Fri, 23 Aug 2002 09:39:13 -0700

   Where are interrupts disabled? I just went through a set of kernprof
   data and traced up the call graph. In the most common __kfree_skb
   case, I do not believe that it has interupts disabled. I could be
   wrong, but I didn't see it.

That's completely right. interrupts should never be disabled when
__kfree_skb is executed. It used to be possible when we allowed
it to be invoked from interrupt handlers, but that is illegal and
we have kfree_skb_irq which just reschedules the actual __kfree_skb
to a software interrupt.

So I agree with you, Mala's claims seem totally bogus and not well
founded at all.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:29 EST