Re: IDE-flash device and hard disk on same controller

From: Eric W. Biederman (ebiederm@xmission.com)
Date: Thu Aug 22 2002 - 00:34:21 EST


Jeff Garzik <jgarzik@mandrakesoft.com> writes:

> Jeff Garzik wrote:
> > Attached is the ATA core...
>
> Just to give a little bit more information about the previously attached code,
> it is merely a module that does two things: (a) demonstrates proper [and
> sometimes faster-than-current-linus] ATA bus probing, and

I am assuming ata_chan_init is the function that does this
demonstration.

I don't see any checking for the ATA bsy flag before you start sending
commands. I have seen the current IDE code fail too many times if I
boot to fast, because of a lack of this one simple test. So I don't
see how this could be considered a proper probe.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:24 EST