Re: [BK PATCH] Still more USB changes for 2.5.31

From: Pete Zaitcev (
Date: Wed Aug 21 2002 - 18:07:19 EST

> From: Greg KH <>
> Date: Wed, 21 Aug 2002 15:49:40 -0700

> ChangeSet@1.514, 2002-08-21 13:53:49-07:00,
> [PATCH] PATCH: fix devices which don't support START_STOP
> Based on my discussions with Pete Zaitcev <>, I'm
> convinced that globally re-writing the START_STOP command into a
> TEST_UNIT_READY command is a good idea. This is supported by the fact
> that:
> (1) Lots of devices don't support START_STOP
> (2) Those that do support it often don't do a good job
> (3) Win/Mac will never send these commands over a USB bus
> So, here's a patch that re-writes them into Test Unit Ready commands.

For the record, I do not think the blanket rewrite is a good idea.
I did it for broken devices only, governed by a new quirk flag,
and this is what we currently ship.

Matt reviewed what I did, but decided it would be cleaner
to rewrite commands always. I did not go on a roll against it because:
 1. 2.5 is supposed to be somewhat broken;
 2. Matt is the module maintainer, he knows what he's doing.

-- Pete
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:24 EST