Re: (RFC): SKB Initialization

From: Benjamin LaHaise (
Date: Wed Aug 21 2002 - 13:16:01 EST

On Wed, Aug 21, 2002 at 01:07:09PM -0500, Mala Anand wrote:
> >On Wed, Aug 21, 2002 at 11:59:44AM -0500, Mala Anand wrote:
> >> The patch reduces the numer of cylces by 25%
> >The data you are reporting is flawed: where are the average cycle
> >times spent in __kfree_skb with the patch?
> I measured the cycles for only the initialization code in alloc_skb
> and __kfree_skb. Since the init code is removed from __kfree_skb,
> no cycles are spent there.

Then the testing technique is flawed. You should include all of the
operations included in an alloc_skb/kfree_skb pair in order to see
the overall effect of the change, otherwise your change could have a
net negative effect which would not be noticed.


"You will be reincarnated as a toad; and you will be much happier."
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:23 EST