Re: [patch, 2.5] vmalloc.c error path fixes

From: Andrew Morton (
Date: Tue Aug 20 2002 - 13:35:33 EST

Marcus Alanen wrote:
> I think there are some problems in vmalloc.c. The two first parts
> of the diff fix a spinlock being held if an error occurs in
> map_vm_area, and the last part fixes the error path of __vmalloc.

Certainly agree on the first chunk. Listen to the old guy: "Thou
shalt not have more than one return statement per function".

Second chunk looks good too, but perhaps there's another way of doing
it. The 2.5.31 code just tossed it all at vfree. Perhaps hch can
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:20 EST