[PATCH] pci_do_scan_bus - 2.5.31

From: Jason Zebchuk (jason@consensys.com)
Date: Mon Aug 19 2002 - 11:56:17 EST


Hi,

    I've found a small problem in the patch I submitted last week to fix
pci_do_scan_bus. The pci_dev that was allocated was not properly
initialised and this could cause any number of problems with booting.

    I've fixed that problem, and I also changed the BUG() to a panic() as
per Andi Kleen's suggestion.

Jason Zebchuk
Consensys RAIDZONE

--- linux-2.5.31/drivers/pci/probe.c Tue Aug 6 12:40:20 2002
+++ linux/drivers/pci/probe.c Mon Aug 19 09:41:43 2002
@@ -505,8 +505,8 @@
        /* Create a device template */
        dev0 = kmalloc(sizeof(struct pci_dev), GFP_ATOMIC);
        if (dev0 == NULL)
- BUG();
- memset(dev0, 0, sizeof(dev0));
+ panic("Unable to allocate pci_dev!");
+ memset(dev0, 0, sizeof(*dev0));
        dev0->bus = bus;
        dev0->sysdata = bus->sysdata;
        dev0->dev.parent = bus->dev;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:17 EST