Re: [PATCH] simplify b_inode usage

From: Christoph Hellwig (
Date: Fri Aug 16 2002 - 07:36:54 EST

On Tue, Aug 13, 2002 at 02:10:10PM -0700, Andrew Morton wrote:
> Current ext3 CVS (ie: 2.4.20 candidate code) is using b_inode
> as an inode *. Stephen has acked a proposal to stop doing that,
> but let's double check with him first.

On IRC he ACKed makeing it a bool.

> Also, Joe Thornber needs to add another pointer to struct buffer_head
> for LVM2 reasons. If we collapse b_inode into a b_flags bit then
> Joe gets his pointer for free (bh stays at 48 bytes on ia32).

We also need to make b_size an 32 bit quantity, otherwise 64k buffers
on architectures like ia64 will get us horrible overflows. And yes,
people use that big pages - Nathan just added an ugly workaround to XFS,
for splitting 64k pages into multiple bh, because of that exactly that

> So I'd suggest you just go ahead and do it that way. (I had a patch
> for that but seem to have misplaced it).

As the patch is already large enough I'd be happy if Marcelo applies the
current patch, once it's in I'll move the indicator to b_flags, okay?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:11 EST