Re: [PATCH] eepro 0.13a

From: Aristeu Sergio Rozanski Filho (aris@cathedrallabs.org)
Date: Tue Jul 30 2002 - 08:48:25 EST

Next message: Geoffrey Lee: "bind()/connect() to port 0 question for tcp/udp"
Previous message: Andi Kleen: "Re: [BK PATCH 2.5] Introduce 64-bit versions of PAGE_{CACHE_,}{MASK,ALIGN}"
In reply to: Andi Kleen: "Re: [PATCH] eepro 0.13a"
Next in thread: Andi Kleen: "Re: [PATCH] eepro 0.13a"
Reply: Andi Kleen: "Re: [PATCH] eepro 0.13a"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> > @@ -633,37 +633,37 @@
> >
> > i = inb(dev->base_addr + ID_REG);
> > printk(KERN_DEBUG " id: %#x ",i);
> > - printk(KERN_DEBUG " io: %#x ", (unsigned)dev->base_addr);
> > + printk(" io: %#x ", (unsigned)dev->base_addr);
> >
> > switch (lp->eepro) {
> > case LAN595FX_10ISA:
> > - printk(KERN_INFO "%s: Intel EtherExpress 10 ISA\n at %#x,",
> > + printk("%s: Intel EtherExpress 10 ISA\n at %#x,",
> > dev->name, (unsigned)dev->base_addr);
>
> [more cases deleted]
>
> This surely can't be right. Why are you dropping all the KERN_*s ?
printk that doesn't start a new line had KERN_* removed because it prints in
the middle of line KERN_* macros like
id: 0xb4 <7> io: 0x340 <6>eth0: Intel EtherExpress Pro/10+ ISA
i had the same reaction but Michael pointed this to me. i don't know exactly
how this macro works, but you'll have the line printed out with the
beggining using KERN_* macro. isn't that sufficient?

-- 
aris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Geoffrey Lee: "bind()/connect() to port 0 question for tcp/udp"
Previous message: Andi Kleen: "Re: [BK PATCH 2.5] Introduce 64-bit versions of PAGE_{CACHE_,}{MASK,ALIGN}"
In reply to: Andi Kleen: "Re: [PATCH] eepro 0.13a"
Next in thread: Andi Kleen: "Re: [PATCH] eepro 0.13a"
Reply: Andi Kleen: "Re: [PATCH] eepro 0.13a"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:36 EST