Re: [PATCH] sd_many done right (3/5)

From: Kurt Garloff (garloff@suse.de)
Date: Mon Jul 29 2002 - 02:52:14 EST


Hi Aron,

On Mon, Jul 29, 2002 at 09:22:40AM +0200, Aron Zeh wrote:
> one little thing:
> In the third "if" statement in scsiname_to_kdev_t you search for "scd" but
> set tp to "sr".
> That should also be "scd" I'd guess.

No, it's intended. Internally, I use the name 'sr' for a SCSI CDrom as
that's the name the driver advertises. Some strange distributions out there
seem to prefer the name 'scd' for unknown reasons[*], that's why I map scd to
sr in order not to confuse users.

[*] The file name of the driver is sr.c, the module is name sr_mod, it fills
in the tag 'sr' as driver name (which is reported in /proc/devices).
But for some reason somebody thinks that 'scd' would be more user friendly.
It may seem more intuitive at first sight, but it makes things completely
inconsistent. Unless, of course, we rename everything to 'scd' to make it
consistent again.
It nowadays is even reported as 'scd' (and 'sr' deprecated) in devices.txt,
sigh!
Somebody should take an authorative decision and do the renames if necessary!
Or make sure devices.txt is fixed. Jens?

Regards,

-- 
Kurt Garloff                   <kurt@garloff.de>         [Eindhoven, NL]
Physics: Plasma simulations    <K.Garloff@TUE.NL>     [TU Eindhoven, NL]
Linux: SCSI, Security          <garloff@suse.de>    [SuSE Nuernberg, DE]
 (See mail header or public key servers for PGP2 and GPG public keys.)


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:31 EST