Re: [announce, patch] Thread-Local Storage (TLS) support for Linux, 2.5.28

From: Oleg Nesterov (oleg@tv-sign.ru)
Date: Sun Jul 28 2002 - 13:44:28 EST


Hello.

I thought, that gdt entry consulted only while
loading its index into the segment register.

So load_TLS_desc(next, cpu) must be called before
loading next->fs,next->gs in __switch_to() ?

--- linux-2.5.29/arch/i386/kernel/process.c~ Sun Jul 28 21:44:35 2002
+++ linux-2.5.29/arch/i386/kernel/process.c Sun Jul 28 21:46:07 2002
@@ -675,6 +675,14 @@
         tss->esp0 = next->esp0;
 
         /*
+ * Load the per-thread Thread-Local Storage descriptor.
+ *
+ * NOTE: it's faster to do the two stores unconditionally
+ * than to branch away.
+ */
+ load_TLS_desc(next, cpu);
+
+ /*
          * Save away %fs and %gs. No need to save %es and %ds, as
          * those are always kernel segments while inside the kernel.
          */
@@ -688,14 +696,6 @@
                 loadsegment(fs, next->fs);
                 loadsegment(gs, next->gs);
         }
-
- /*
- * Load the per-thread Thread-Local Storage descriptor.
- *
- * NOTE: it's faster to do the two stores unconditionally
- * than to branch away.
- */
- load_TLS_desc(next, cpu);
 
         /*
          * Now maybe reload the debug registers

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:29 EST