Hello.
Oleg Nesterov wrote:
> + irq_enter();
> (*func)(info);
> + irq_exit();
It is better to update call_data->finished before
doing soft irqs in irq_exit().
Against 2.5.28:
--- arch/i386/kernel/smp.c~ Fri Jul 26 07:49:03 2002
+++ arch/i386/kernel/smp.c Fri Jul 26 09:29:20 2002
@@ -646,10 +646,12 @@
/*
* At this point the info structure may be out of scope unless wait==1
*/
+ irq_enter();
(*func)(info);
if (wait) {
mb();
atomic_inc(&call_data->finished);
}
+ irq_exit();
}
--- arch/i386/kernel/entry.S~ Fri Jul 26 07:49:03 2002
+++ arch/i386/kernel/entry.S Fri Jul 26 07:57:48 2002
@@ -417,7 +417,6 @@
ENTRY(device_not_available)
pushl $-1 # mark this as an int
SAVE_ALL
- GET_THREAD_INFO(%ebx)
movl %cr0, %eax
testl $0x4, %eax # EM (math emulation bit)
jne device_not_available_emulate
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:22 EST