On Thu, 25 Jul 2002, Zwane Mwaikambo wrote:
> On Thu, 25 Jul 2002, Samuel Thibault wrote:
>
> > static void qd_write_reg (byte content, byte reg)
> > {
> > unsigned long flags;
> >
> > - save_flags(flags); /* all CPUs */
> > - cli(); /* all CPUs */
> > + spin_lock_irqsave(&qd_iolock,flags);
> > outb(content,reg);
>
> Do we need a lock/cli for that one outb?
>
> > + spin_unlock_irqrestore(&qd_iolock,flags);
Well, I put it since many ide chipset drivers put it, but we may indeed
get rid of it, provided the board isn't upset when parallel selectprocing
/ tuning on ide0 and ide1. I won't be able to test before September.
Oh, btw, I only use one spinlock for timing computing, while there could
be one per QD channel, which would speed up tunig :o)
-- Samuel Thibault <samuel.thibault@fnac.net> Hi ! I'm a .signature virus ! Copy me into your ~/.signature, please !- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:21 EST