Re: [RFC/CFT] cmd640 irqlocking fixes

From: Marcin Dalecki (dalecki@evision.ag)
Date: Thu Jul 25 2002 - 03:01:38 EST


William Lee Irwin III wrote:
> I don't have one of these, and I'm not even sure what it is. But here's
> a wild guess at a fix.
>
>
> Cheers,
> Bill
> ===== drivers/ide/cmd640.c 1.11 vs edited =====
> --- 1.11/drivers/ide/cmd640.c Wed May 22 04:21:11 2002
> +++ edited/drivers/ide/cmd640.c Wed Jul 24 18:51:54 2002
> @@ -115,6 +115,12 @@
> #include "ata-timing.h"
>
> /*
> + * Is this remotely correct?
> + */

The proper fix (rating: 50% propability of beeing perfect and 99.99%
propability of working) is just to *remove* those georgeous IRQ
"tooglers" *alltogether*. Scrap them... becouse I don't see how any
of the encolosed commands could cause an IRQ...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:19 EST