Re: [PATCH] updated low-latency zap_page_range

From: Andrew Morton (akpm@zip.com.au)
Date: Wed Jul 24 2002 - 20:19:27 EST


Robert Love wrote:
>
> ...
> I hope it compiles to nothing! There is a false in an if... oh, wait,
> to preserve possible side-effects gcc will keep the need_resched() call
> so I guess we should reorder it as:
>
> if (preempt_count() == 1 && need_resched())
>
> Then we get "if (0 && ..)" which should hopefully be evaluated away.
> Then the inline is empty and nothing need be done.

I think someone changed the definition of preempt_count()
while you weren't looking.

Plus it's used as an lvalue :(

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:18 EST