Re: [patch] irqlock patch 2.5.27-H4

From: Marcin Dalecki (dalecki@evision.ag)
Date: Wed Jul 24 2002 - 08:13:37 EST


Bartlomiej Zolnierkiewicz wrote:
> On Wed, 24 Jul 2002, Ingo Molnar wrote:
>
>
>>the latest irqlock patch can be found at:
>>
>> http://redhat.com/~mingo/remove-irqlock-patches/remove-irqlock-2.5.27-H4
>>
>>Changes in -H4:
>>
>> - fix the cli()/sti() hack in ide/main.c, per Marcin Dalecki's
>> suggestion. [this leaves the tty layer as the only remaining subsystem
>> that still has cli()/sti() related hacks.]
>
>
> Hi Ingo,
>
> Marcin's suggestions will bring you nowhere.
>
> You should remove all these locking from ide_unregister_subdriver()
> because in 100% cases it is already called with ide_lock held.

Indeed they can be just removed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 30 2002 - 14:00:15 EST