On 11 Jul 02 at 1:26, Albert Cranford wrote:
> Hello Linus,
> Could you please apply these 3 patches toward 2.5.26.
> They include Config.in updates, additions in i2c-id.h
> for "Video for Linux" and a compatibility fix for
> i2c-algo-bit.c
Hi,
is timeout field in i2c_algo_bit_data supposed to be in jiffies
(like it is currently used) or in 10ms units? If it is supposed
to be in jiffies (other algos do not care about timeout field),
there is dozen of places (all callers of i2c_bit_add_bus) which
get it wrong.
Next suspicious thing is that 'timeout' field from i2c_adapter
structure is not used at all - only i2c_control is willing to
set it, but nobody reads this field. Should not i2c_bit_add_bus
copy its timeout into this field, and then use adap->timeout instead
of bitadap->timeout in its sclhi() procedure?
Thanks,
Petr Vandrovec
vandrove@vc.cvut.cz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Jul 15 2002 - 22:00:19 EST