Re: [patch 18/27] always update page->flags atomically

From: Russell King (rmk@arm.linux.org.uk)
Date: Fri Jul 05 2002 - 04:06:37 EST

Next message: William Lee Irwin III: "Re: [OKS] O(1) scheduler in 2.4"
Previous message: Christian Berger: "(no subject)"
In reply to: Andrew Morton: "[patch 18/27] always update page->flags atomically"
Next in thread: Andrew Morton: "Re: [patch 18/27] always update page->flags atomically"
Reply: Andrew Morton: "Re: [patch 18/27] always update page->flags atomically"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Jul 04, 2002 at 04:54:50PM -0700, Andrew Morton wrote:
> It had no right to go clearing PG_arch_1. I'm now clearing PG_arch_1
> inside rmqueue() which is still a bit presumptious.

Davem should know the right behaviour for this bit. It's not a generic
"architecture" bit, but it has some defined behaviour behind it. See
cachetlb.txt:

  void flush_dcache_page(struct page *page)
...
        There is a bit set aside in page->flags (PG_arch_1) as
        "architecture private". The kernel guarantees that,
        for pagecache pages, it will clear this bit when such
        a page first enters the pagecache.

I think you may have broken this... ;(

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: William Lee Irwin III: "Re: [OKS] O(1) scheduler in 2.4"
Previous message: Christian Berger: "(no subject)"
In reply to: Andrew Morton: "[patch 18/27] always update page->flags atomically"
Next in thread: Andrew Morton: "Re: [patch 18/27] always update page->flags atomically"
Reply: Andrew Morton: "Re: [patch 18/27] always update page->flags atomically"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jul 07 2002 - 22:00:15 EST