Re: [PATCH] 2.5.24 IDE 97

From: Russell King (rmk@arm.linux.org.uk)
Date: Thu Jul 04 2002 - 08:29:38 EST


On Wed, Jul 03, 2002 at 12:22:11AM +0200, Bartlomiej Zolnierkiewicz wrote:
> This patch is a accumulation of ata-hosts-7/8/9/10/11, ata-autodma
> and ata-ata66_check patches previously posted on LKML.

>From a first review only, it looks like this patch prevents the chipset
drivers from disabling DMA mode on initialisation. This is Really Bad(tm)
since some revisions of some chipsets must _never_ be placed into DMA
mode due to hardware bugs. Even if the user selects CONFIG_IDEDMA_AUTO.

The code in sl82c105.c knows about the chipset revisions that this is
required for, and it looks like the code in ide-pci.c will override the
chipset if CONFIG_IDEDMA_AUTO is enabled.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 07 2002 - 22:00:13 EST