Remove CM206_BH

From: Matthew Wilcox (willy@debian.org)
Date: Mon Jun 17 2002 - 08:18:47 EST

Hi David. My quest to kill Bottom Halves continues, and I've stumbled
into your driver. Can you test to see if this works, please?

--- linux-2.5.22/drivers/cdrom/cm206.c Mon Jun 17 04:49:04 2002
+++ linux-2.5.22-bh/drivers/cdrom/cm206.c Mon Jun 17 05:42:50 2002
@@ -345,6 +345,8 @@
         }
 }
 
+static struct tasklet_struct cm206_tasklet;
+
 /* The interrupt handler. When the cm260 generates an interrupt, very
    much care has to be taken in reading out the registers in the right
    order; in case of a receive_buffer_full interrupt, first the
@@ -432,7 +434,7 @@
         if (cd->background
             && (cd->adapter_last - cd->adapter_first == cd->max_sectors
                 || cd->fifo_overflowed))
- mark_bh(CM206_BH); /* issue a stop read command */
+ tasklet_schedule(&cm206_tasklet); /* issue a stop read command */
         stats(interrupt);
 }
 
@@ -701,7 +703,7 @@
    4 c_stop waits for receive_buffer_full: 0xff
 */
 
-void cm206_bh(void)
+static void cm206_tasklet_func(unsigned long ignore)
 {
         debug(("bh: %d\n", cd->background));
         switch (cd->background) {
@@ -745,6 +747,8 @@
         }
 }
 
+static DECLARE_TASKLET(cm206_tasklet, cm206_tasklet_func, 0);
+
 /* This command clears the dsb_possible_media_change flag, so we must
  * retain it.
  */
@@ -1503,7 +1507,6 @@
         blk_init_queue(BLK_DEFAULT_QUEUE(MAJOR_NR), do_cm206_request,
                        &cm206_lock);
         blk_queue_hardsect_size(BLK_DEFAULT_QUEUE(MAJOR_NR), 2048);
- init_bh(CM206_BH, cm206_bh);
 
         memset(cd, 0, sizeof(*cd)); /* give'm some reasonable value */
         cd->sector_last = -1; /* flag no data buffered */ 

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:13 EST