Re: RFC: per-socket statistics on received/dropped packets

From: Horst von Brand (vonbrand@inf.utfsm.cl)
Date: Wed Jun 12 2002 - 07:11:45 EST


[Cc:'s stripped]

Ben Greear <greearb@candelatech.com> said:
> Pekka Savola wrote:
> > Just to chime in my support (not that I don't think anyone needs it), I
> > think socket-based counters are An Extremely Bad Idea.

[...]

> If they are useful to some people, and have zero performance affect on others
> (due to being a configurable kernel feature), then what is your
> complaint?

That it adds code, which impacts _everybody_ futzing around in that area,
specially if it is a configurable option (this means multiplying the
possible configurations to be tested).

> I see two reasons left to dislike this feature:
>
> 1) General increase in #ifdef'd code. This actually seems like
> a pretty good argument, but I haven't seen anyone mention it
> specifically.

Right.

> 2) General dislike for a feature that one personally has no use for.
> Seems to be Dave's main (professed) excuse.

General dislike for adding features of _extremely_ limited (debugging!) use?

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:25 EST