Re: [patch 1/10] suppress allocation warnings for radix-tree allocations

From: Andrew Morton (akpm@zip.com.au)
Date: Sun May 05 2002 - 17:06:10 EST


Daniel Phillips wrote:
>
> On Sunday 05 May 2002 22:53, Andrew Morton wrote:
> > The recently-added page allocation failure warning generates a lot of
> > noise due to radix-tree node allocation failures. Those messages are
> > not interesting.
> >
> > But I think the warning is otherwise useful - "I got an allocation
> > failure and then it crashed" is better than "it crashed".
> >
> > The patch suppresses the message for ratnode allocation failures.
> >
> > =====================================
> >
> > --- 2.5.13/mm/vmscan.c~radix-tree-warning Sun May 5 13:31:59 2002
> > +++ 2.5.13-akpm/mm/vmscan.c Sun May 5 13:31:59 2002
> > @@ -58,6 +58,7 @@ swap_out_add_to_swap_cache(struct page *
> > int ret;
> >
> > current->flags &= ~PF_MEMALLOC;
> > + current->flags |= PF_RADIX_TREE;
>
> Isn't that really 'PF_NO_WARN_ALLOC'?
>

Yup, that would make more sense.

Or __GFP_I_DONT_REALLY_CARE ;)

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 07 2002 - 22:00:25 EST