Re: Linux 2.5.13-dj2

From: Adrian Bunk (bunk@fs.tum.de)
Date: Sat May 04 2002 - 11:16:29 EST

Next message: rddunlap@osdl.org: "Re: kbuild 2.5 release 2.4"
Previous message: Antonino Daplas: "Re: [Linux-fbdev-devel] Comments on fbgen.c and fbcon-accel.c"
In reply to: Dave Jones: "Linux 2.5.13-dj2"
Next in thread: Christoph Hellwig: "Re: Linux 2.5.13-dj2"
Reply: Christoph Hellwig: "Re: Linux 2.5.13-dj2"
Reply: Oliver Pitzeier: "2.5.13 on Alpha don't likes me!!!!!!!!!! - A non sucess story. 2.5.11 worked fine!"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Dave,

I got the following compile error in cpqfcTSinit.c:

<-- snip -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.5/linux-2.5.13/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc -I
/usr/lib/gcc-lib/i386-linux/2.95.4/include -DKBUILD_BASENAME=cpqfcTSinit
-c -o cpqfcTSinit.o cpqfcTSinit.c
cpqfcTSinit.c: In function `cpqfcTS_ioctl':
cpqfcTSinit.c:535: `CAP_RAW_IO' undeclared (first use in this function)
cpqfcTSinit.c:535: (Each undeclared identifier is reported only once
cpqfcTSinit.c:535: for each function it appears in.)
cpqfcTSinit.c: At top level:
cpqfcTSinit.c:1979: unknown field `reset' specified in initializer
cpqfcTSinit.c:1979: duplicate initializer
cpqfcTSinit.c:1979: (near initialization for
`driver_template.eh_device_reset_handler')
cpqfcTSinit.c:1979: unknown field `abort' specified in initializer
make[3]: *** [cpqfcTSinit.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.5/linux-2.5.13/drivers/scsi'

<-- snip -->

The first part of the error message is strange. 2.5.13-dj2 does exactly
the following change to this file:

--- linux-2.5.13/drivers/scsi/cpqfcTSinit.c Fri May 3 01:22:40 2002
+++ linux-2.5/drivers/scsi/cpqfcTSinit.c Fri May 3 12:28:12 2002
@@ -532,7 +532,7 @@

         // must be super user to send stuff directly to the
         // controller and/or physical drives...
- if( !capable(CAP_SYS_ADMIN) )
+ if( !capable(CAP_RAW_IO) )
           return -EPERM;

// copy the caller's struct to our space.

This is the only place in the 2.5.13-dj2 patch where CAP_RAW_IO is
mentioned and a grep showed that it's the only occurence of CAP_RAW_IO in
the whole 2.5.13-dj2 kernel sources:

<-- snip -->

~/linux/kernel-2.5/linux-2.5.13$ grep -r CAP_RAW_IO *
drivers/scsi/cpqfcTSinit.c: if( !capable(CAP_RAW_IO) )
~/linux/kernel-2.5/linux-2.5.13$

<-- snip -->

cu
Adrian

You only think this is a free country. Like the US the UK spends a lot of time explaining its a free country because its a police state. Alan Cox

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: rddunlap@osdl.org: "Re: kbuild 2.5 release 2.4"
Previous message: Antonino Daplas: "Re: [Linux-fbdev-devel] Comments on fbgen.c and fbcon-accel.c"
In reply to: Dave Jones: "Linux 2.5.13-dj2"
Next in thread: Christoph Hellwig: "Re: Linux 2.5.13-dj2"
Reply: Christoph Hellwig: "Re: Linux 2.5.13-dj2"
Reply: Oliver Pitzeier: "2.5.13 on Alpha don't likes me!!!!!!!!!! - A non sucess story. 2.5.11 worked fine!"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue May 07 2002 - 22:00:22 EST