On Fri, 5 Apr 2002, Dave Hansen wrote:
>
> My patch adds a semaphore to the inode structure,
Hmm... I'd really prefer to just use the existing i_sem - umsdos doesn't
work as-is right now anyway, but as far as I can see that's really what
umsdos actually wants anyway (ie then you can just remove the down/up from
the UMSDOS_notify_change() routine).
do_truncate() already does the i_sem thing for its notify_change, and
notify_change() really _is_ equivalent to a write, so this really seems to
make more sense that way.
Just move the current down/up pair from do_truncate() into notify_change()
(it also protects the "newattrs" assignment in do_truncate, but that is
purely local data at that point and needs no protection).
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Apr 07 2002 - 22:00:17 EST