> - spin_unlock_irq(&io_request_lock);
> + spin_unlock_irqrestore(&io_request_lock, flags);
> rq = kmem_cache_alloc(request_cachep, SLAB_KERNEL);
Great patch.
kmem_cache_alloc with SLAB_KERNEL can sleep, i.e. you've just converted
an obvious bug into a rare, difficult to find bug. What about trying to
fix it?
I agree that this won't happen during boot, but what about a hotplug PCI
ide controller?
--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Mar 31 2002 - 22:00:19 EST