Re: [patch] ext2_fill_super breakage

From: Bill Davidsen (davidsen@tmr.com)
Date: Thu Mar 28 2002 - 19:42:03 EST


On Thu, 28 Mar 2002, Andrew Morton wrote:

> I'm not particularly fussed about this one, but I do prefer
> the sleep-at-night safety of a blanket memset. Because
> (and I think this is something on which you and I somewhat
> differ) code should be written for the convenience of others,
> not the original author. A nice memset will leave no doubt
> in the reader's mind that all members of the structure have
> been initialised.

  Definitely. It's easy to forget to initialize something when you reuse a
struct.

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 31 2002 - 22:00:17 EST