Re: [PATCH] 3c59x and resume

From: christophe barbé (christophe.barbe.ml@online.fr)
Date: Sun Mar 24 2002 - 09:25:45 EST

On Sun, Mar 24, 2002 at 12:07:29AM -0800, Greg KH wrote:
> On Sat, Mar 23, 2002 at 05:44:33PM -0500, christophe barbé wrote:
> > With the 'everything is module' and 'everything is hotplug' approach in
> > mind (which is a appealing way and IMHO this is the way we are going),
> > I see two part for this problem:
> >
> > . Persistence after plug out/plug in
> >
> > . Persistence after suspend/resume
> >
> > The first one is a userland problem. The card identification could be
> > based on the MAC address (for NICs at least, in the case of cardbus the
> > bus position has no real signification). This should then be the
> > responsibility of the userspace tool (hotplug) to indicate the correct
> > option for this card. The problem is when the module is already loaded,
> > the userspace tool has no way to indicate this option.
>
> Untrue. See
> http://www.kroah.com/linux/hotplug/ols_2001_hotplug_talk/html/mgp00014.html
> for a 6 line version of /sbin/hotplug that always assigns the same
> "ethX" value to the same MAC address. I think the patch to nameif has
> gone in to support this, but I'm not sure.

Untrue what ? The persistence after plug out/in ?
The problem here is not to give the same interface to a given NIC. The
problem is to give the same options to a given NIC. But a solution can
simply be to set the option from hotplug using the proc interface. The
3c59x doesn't support that for wol but that can be changed.

> And why is there a limitation of only 8 devices? Why not do what all
> USB drivers do, and just create the structure that you need to use at
> probe() time, and destroy it at remove() time?

This is an implementation issue which is not really important. It comes
from Donald Becker. Your dynamic structure doesn't solve the problem
'which options for which cards', does it ?

> Just my $0.02
>
> thanks,
>
> greg k-h

Thanks,
Christophe 

-- 
Christophe Barbé <christophe.barbe@ufies.org>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

There's no sense in being precise when you don't even know what you're
talking about. -- John von Neumann
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Mar 31 2002 - 22:00:07 EST