Re: [PATCH] Submitting PROMISE IDE Controllers Driver Patch

From: Andrzej Krzysztofowicz (ankry@green.mif.pg.gda.pl)
Date: Thu Mar 07 2002 - 08:36:38 EST


> > /* Give size in megabytes (MB), not mebibytes (MiB). */
> > /* We compute the exact rounded value, avoiding overflow. */
> > - printk (" (%ld MB)", (capacity - capacity/625 + 974)/1950);
> > + printk (" (%ld GB)", ((capacity - capacity/625 + 974)/1950)/1024);
>
> We use Mb for a reason (old disks look odd) - maybe using Gb once its >=
> 2Gb would work to make it look neater ?

And please, use well defined units. Here
1GB = 1024 * 10^6 bytes

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:01:03 EST