In article <3C86BEB0.4090203@us.ibm.com> you wrote:
>> Any reason for preferring this over the sard patches in -ac ?
>>
> Basically, statistic data are moved from the global kstat structure
Why do you think sard uses kstat?
> to
> the request_queue structures, and it is allocated/freed when the request
> queue is initialized and freed. This way it is
> 1)self-controlled;
> 2)avoid the lookup step before the accounting, so it should be faster;
in 2.4.18+ get_gendisk is O(1) - the lookup is not costly at all.
> 3)statistics implementation is not affected by the major/minor numbers;
Gendisks currently are per-major, which is a disadvantage, but the sard
code itself is not affected by that.
> 4)able to gathering statistics for all disks while keep the memory needs
> minimized.
The same is true for sard.
Somehow I think you haven't actually looked at the sard code in -ac..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:01:02 EST