Re: [PATCH] IBM Lanstreamer bugfixes (round 3)

From: David Dillow (dillowd@y12.doe.gov)
Date: Mon Mar 04 2002 - 14:02:14 EST


Jeff Garzik wrote:
>
> David Dillow wrote:
> > Right, I was talking more about the cache line size... is it sufficient
> > for that?
>
> pci_enable_device doesn't touch PCI_COMMAND_INVALIDATE either, on most
> platforms (particularly ia32, i.e. the popular one :))

Doh! I see my mistake; I was reading pdev_enable_device() which sets it
to L1_CACHE_BYTES. And a quick grep shows me that it is called from
pci_assign_unassigned_resources(), which is not called on ia32 as far as
I can see....

This seems to be a common thing to set; shouldn't we have a helper for
it as well, or have pci_enable_device() do it?

Thanks,
Dave Dillow
dillowd@y12.doe.gov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:35 EST