Re: [PATCH] spinlock not locked when unlocking in atm_dev_register

From: Robert Love (rml@tech9.net)
Date: Mon Mar 04 2002 - 13:58:33 EST


On Mon, 2002-03-04 at 03:29, Frode Isaksen wrote:

> The atm_dev_register function is calling functions that are using the same
> spinlock, so you cannot just lock the spinlock when entering the function..

Ah, OK -- my apologies. Then, a few things need to be checked:

        - atm_dev_register (ignoring its callees) does not need a lock
        - every callee of atm_dev_register that does need the lock
          acquires and releases it itself (this is good design, too)

I suspect the second point may be missing the releases in cases, since
those spin_unlocks were in the code.

        Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:35 EST