Re: [Linux-fbdev-devel] [PATCH] hitfb ported to new api.

• Next message: Daniel Phillips: "Re: [patch] delayed disk block allocation"
• Previous message: Stelian Pop: "Re: Linux 2.5.6-pre2 and ALSA Sound"
• In reply to: James Simmons: "[PATCH] hitfb ported to new api."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, 2 Mar 2002, James Simmons wrote:
> +static struct fb_var_screeninfo hitfb_var __initdata = {
> + 0, 0, 0, 0, 0, 0, 0, 0,
> + {0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0},
> + 0, FB_ACTIVATE_NOW, -1, -1, 0, 0, 0, 0, 0, 0, 0, 0,
> + 0, FB_VMODE_NONINTERLACED
> };

> +static struct fb_fix_screeninfo hitfb_fix __initdata = {
> + "Hitachi HD64461",(unsigned long) NULL, 0, FB_TYPE_PACKED_PIXELS,
> + 0, FB_VISUAL_TRUECOLOR, 0, 0, 0, 0, (unsigned long) NULL, 0,
> + FB_ACCEL_NONE
> };

Suggestion: use the new-style struct initialization. It's less error-prone, and
you can get rid of the 0/NULL values.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Daniel Phillips: "Re: [patch] delayed disk block allocation"
• Previous message: Stelian Pop: "Re: Linux 2.5.6-pre2 and ALSA Sound"
• In reply to: James Simmons: "[PATCH] hitfb ported to new api."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:32 EST