[patch] Re: 2.4.19-pre2: ufs problems

From: Andries.Brouwer@cwi.nl
Date: Sun Mar 03 2002 - 19:35:15 EST


Both Gerd Knorr and Jurgen Philippaerts complain about
problems mounting an ufs filesystem, one for BSD, the
other for Solaris.
The reason is the patch fragment in patch-2.4.19-pre2:

--- linux.orig/fs/ufs/super.c Thu Feb 28 18:24:57 2002
+++ linux/fs/ufs/super.c Wed Feb 27 20:34:30 2002
@@ -597,7 +597,11 @@
        }

 again:
- set_blocksize (sb->s_dev, block_size);
+ if (!set_blocksize (sb->s_dev, block_size)) {
+ printk(KERN_ERR "UFS: failed to set blocksize\n");
+ goto failed;
+ }
+
        sb->s_blocksize = block_size;

        /*

Indeed, set_blocksize returns 0 when all is well.
Thus, this change will always cause a failure.

Andries

[so, this patch fragment must be reverted, or the '!'
must be removed]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:29 EST