[PATCH] spinlock not locked when unlocking in atm_dev_register

From: Frode Isaksen (fisaksen@bewan.com)
Date: Fri Mar 01 2002 - 12:46:28 EST


If you compile the kernel with SMP and spinlock debugging, BUG() will be
called when registering your atm driver, since the "atm_dev_lock" spinlock is
not locked when unlocking it.

kernel 2.4.18

Regards,
Frode

--- resources.c.orig Fri Mar 1 18:34:02 2002
+++ resources.c Fri Mar 1 18:34:17 2002
@@ -110,12 +110,10 @@
                 if (atm_proc_dev_register(dev) < 0) {
                         printk(KERN_ERR "atm_dev_register: "
                             "atm_proc_dev_register failed for dev %s\n",type);
- spin_unlock (&atm_dev_lock);
                         free_atm_dev(dev);
                         return NULL;
                 }
 #endif
- spin_unlock (&atm_dev_lock);
         return dev;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:16 EST