Re: [PATCH] via-rhine for 2.5.5

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Thu Feb 21 2002 - 05:18:24 EST


Stephane Casset wrote:
> --- drivers/net/via-rhine.c.orig Thu Feb 21 10:49:54 2002
> +++ drivers/net/via-rhine.c Thu Feb 21 10:55:39 2002
> @@ -1754,7 +1754,7 @@
> - remove: via_rhine_remove_one,
> + remove: __devexit_p(via_rhine_remove_one),

this is ok

> -static void __exit via_rhine_cleanup (void)
> +static void __devexit via_rhine_cleanup (void)

this is definitely wrong

I'm also surprised you managed to compile via-rhine without the attached
patch, which is needed to fix the build.

        Jeff

-- 
Jeff Garzik      | "Why is it that attractive girls like you
Building 1024    |  always seem to have a boyfriend?"
MandrakeSoft     | "Because I'm a nympho that owns a brewery?"
                 |             - BBC TV show "Coupling"

diff -Nru a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c --- a/drivers/net/via-rhine.c Thu Feb 21 05:17:43 2002 +++ b/drivers/net/via-rhine.c Thu Feb 21 05:17:43 2002 @@ -321,6 +321,7 @@ VT86C100A = 0, VT6102, VT3043, + VT6105, }; struct via_rhine_chip_info { @@ -349,7 +350,7 @@ { "VIA VT6102 Rhine-II", RHINE_IOTYPE, 256, CanHaveMII | HasWOL }, { "VIA VT3043 Rhine", RHINE_IOTYPE, 128, - CanHaveMII | ReqTxAlign } + CanHaveMII | ReqTxAlign }, { "VIA VT6105 Rhine-III", RHINE_IOTYPE, 256, CanHaveMII | HasWOL }, };

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Feb 23 2002 - 21:00:31 EST