Re: gnome-terminal acts funny in recent 2.5 series

From: OGAWA Hirofumi (hirofumi@mail.parknet.co.jp)
Date: Tue Feb 19 2002 - 06:44:39 EST


Alessandro Suardi <alessandro.suardi@oracle.com> writes:

> Running Ximian-latest for rh72/i386, latest 2.5 kernels (including
> 2.5.4-pre2, 2.5.4, 2.5.5-pre1).
>
> Symptom:
> - clicking on the panel icon for gnome-terminal shows a flicker
> of the terminal window coming up then the window disappears.
> No leftover processes.
>
> What works 100%:
> - regular xterm in 2.5.x
> - gnome-terminal in 2.4.x (x in .17, .18-pre9, .18-rc2)
>
> More info:
> - doesn't happen 100% of the time, but close
> - trying to start gnome-terminal either vanilla or with the
> parameters in the icon from an xterm causes
> * gnome-terminal window comes up, but no shell prompt; the
> window *does not* disappear and program is in a CPU loop
> * program detaches from calling xterm even when '&' is
> not used
> * calling xterm's tty is left in a funny state (sometimes
> stty sane^J is required, sometimes tput reset)
>
> Any ideas would be quite welcome - I can go back and try and narrow
> down what kernel breaks gnome-terminal if nothing comes up.

Probably, this problem had occurred in libzvt which gnome-terminal is
using.

libzvt was using file descriptor passing via UNIX domain socket for
pseudo terminal. Then because ->passcred was not initialized in
sock_alloc(), unexpected credential data was passing to libzvt.

The following patch fixed this problem, but I'm not sure.
Could you review the patch? (attached file are test program)

--- socket.c.orig Mon Feb 11 18:21:59 2002
+++ socket.c Tue Feb 19 16:20:18 2002
@@ -501,6 +501,8 @@ struct socket *sock_alloc(void)
         sock->ops = NULL;
         sock->sk = NULL;
         sock->file = NULL;
+// init_waitqueue_head(&sock->wait); this is needed?
+ sock->passcred = 0;
 
         sockets_in_use[smp_processor_id()].counter++;
         return sock;

Regards

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Feb 23 2002 - 21:00:19 EST