On Saturday 09 February 2002 19:46, Gerd Knorr wrote:
> Hi,
>
> The patch below does part one of the plan -- for 2.4.x kernels. It adds
> the fops pointer to struct video_device and makes video_open use it if
> available, so both old + new style drivers will work.
>
> It also provides a ioctl wrapper function which handles copying the
> ioctl args from/to userspace, so we have this at one place can drop all
> the copy_from/to_user calls within the v4l device driver ioctl handlers.
That is a large improvement.
But you don't include a lock against reentry, which is bad.
> Comments?
Could you make a helper for open like for ioctl ?
And please don't use a pointer to the device descriptor
in the file structure. It makes live for USB devices much harder.
Regards
Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:28 EST