Re: [PATCH] read() from driverfs files can read more bytes

From: Patrick Mochel (mochel@osdl.org)
Date: Thu Feb 07 2002 - 15:21:41 EST


On Thu, 7 Feb 2002, Petr Vandrovec wrote:

> On 7 Feb 02 at 10:27, Patrick Mochel wrote:
>
> > Concerning reading/writing from offsets, it's up to the drivers for them
> > to either support it or not. In the files I've done so far, I return 0 if
> > show() is called with an offset. Which will give different results if you
> > read byte-by-byte or an entire chunk.
> >
> > It makes the callbacks simpler, but it is not technically correct.
>
> What about extremelly nice stuff Al Viro made for us in
> fs/seq_file.c ? It made putting stuff into procfs really easy...

It is really nice, but it's too much for the common case. The goal is to
have each file export one and only one value. Setting up an iterator is
overkill for one value.

        -pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Feb 07 2002 - 21:01:06 EST