Re: [PATCH 2.5.3] wavelan_cs.c : new WE api

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Mon Feb 04 2002 - 21:36:18 EST

Next message: Clifford Kite: "Kernel zombie threads after module removal."
Previous message: Philippe Troin: "Re: How to crash a system and take a dump?"
In reply to: Jean Tourrilhes: "[PATCH 2.5.3] wavelan_cs.c : new WE api"
Next in thread: Jean Tourrilhes: "Re: [PATCH 2.5.3] wavelan_cs.c : new WE api"
Reply: Jean Tourrilhes: "Re: [PATCH 2.5.3] wavelan_cs.c : new WE api"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Comments pertaining to all three of wavelan, wavelan_cs, and netwave_cs:
* wv_splhi should really just be spin_lock_irqsave. calling
spin_lock_irqsave with 'flags' from another function is non-portable.
doing so to an inline function is just barely portable, and is
discouraged :)
* I still see a couple save_flags/restore_flags in there...

otherwise looks ok to me.

-- 
Jeff Garzik      | "I went through my candy like hot oatmeal
Building 1024    |  through an internally-buttered weasel."
MandrakeSoft     |             - goats.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Clifford Kite: "Kernel zombie threads after module removal."
Previous message: Philippe Troin: "Re: How to crash a system and take a dump?"
In reply to: Jean Tourrilhes: "[PATCH 2.5.3] wavelan_cs.c : new WE api"
Next in thread: Jean Tourrilhes: "Re: [PATCH 2.5.3] wavelan_cs.c : new WE api"
Reply: Jean Tourrilhes: "Re: [PATCH 2.5.3] wavelan_cs.c : new WE api"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Feb 07 2002 - 21:00:40 EST