[PATCH] Specialix RIO Oops fix

From: Steven Pritchard (steve@silug.org)
Date: Mon Feb 04 2002 - 10:02:00 EST


The patch below fixes an Oops in the Specialix RIO driver. I sent
this to the maintainer a couple of months ago and never got a
response.

Note that this patch doesn't actually make the driver *work* for my
client... It still causes a hard lockup that I was unable to debug in
the short time I had to work on it. Specialix apparently told my
client that they would have to switch to the original Red Hat 7.1
kernel (2.4.2-something) if they wanted it to actually work.

In any case, this patch seems to be a no-brainer. It merely adds a
check that I see in every other serial driver's set_real_termios()
function.

Steve

-- 
steve@silug.org           | Southern Illinois Linux Users Group
(618)398-7360             | See web site for meeting details.
Steven Pritchard          | http://www.silug.org/

--- linux-2.4.17.orig/drivers/char/rio/rio_linux.c Thu Oct 25 15:53:47 2001 +++ linux-2.4.17/drivers/char/rio/rio_linux.c Mon Feb 4 08:53:34 2002 @@ -422,6 +422,11 @@ struct tty_struct *tty; func_enter(); + if (!((struct Port *)ptr)->gs.tty || !((struct Port *)ptr)->gs.tty->termios) { + func_exit(); + return 0; + } + tty = ((struct Port *)ptr)->gs.tty; modem = (MAJOR(tty->device) == RIO_NORMAL_MAJOR0) || (MAJOR(tty->device) == RIO_NORMAL_MAJOR1); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Feb 07 2002 - 21:00:34 EST