Richard Gooch wrote:
>
> > Instead, it appears that someone broke tty_name(). Here's the
> > 2.2 kernel's version:
>
> That "someone" was me, and I changed it from broken to fixed.
>
Look at serial.c:
#if (LINUX_VERSION_CODE > 0x2032D && defined(CONFIG_DEVFS_FS))
serial_driver.name = "tts/%d";
#else
serial_driver.name = "ttyS";
#endif
tty_name will just print "ttyS". So the transition for this case
was fixed->broken.
>
> No, originally tty_name() did it, and then I shifted it to the
> drivers. I don't recall the reason, but it was necessary. So I don't
> want this changed.
Oh dear. Why cannot devfs expand the minor part itself?
It looks like all the drivers need to be given a %d, as Ivan suggests. And we
need to audit all uses to make sure nobody is doing printk(driver.name);
I think it would be better to drop the printf control construct from the
names altogether.
-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:20 EST