Re: [PATCH] fix loop with disabled tasklets

From: Mathijs Mohlmann (mathijs@webflex.nl)
Date: Mon Nov 12 2001 - 04:11:20 EST


On 12-Nov-2001 Momchil Velikov wrote:
> In this patch, the first thing is to deschedule the tasklet. So, the
> changes to interrupt.h are needed in order to put back the tasklet in
> the queue.
I know, but Andrea suggested not to allow scheduling of disabled tasklets
Also, enableing the tasklet will result in a scheduled tasklet, regardless
whether it was scheduled. Plus, we are not sure if it is scheduled on the
same cpu that did the tasklet_schedule (but i might be the only one who
cares about this ;)

> Mathijs> thisone we should add some comments to interrupt.h warning
> Mathijs> about deadlocks etc.
> What deadlocks ? ;)
well, loops. Dont use tasklet_kill on disabled tasklet or on not scheduled
tasklets.

        me

-- 
        me
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 15 2001 - 21:00:28 EST