On Friday 09 November 2001 21:45, Robert Love wrote:
> I went over the patch and found a few things...
>
> printk(KERN_INFO "No local APIC present or hardware disabled\n");
>
> I'd make this a KERN_WARNING. Consider the case where I compile my own
> kernel and I add APIC support. If the driver is failing to find my APIC
> then either (a) my BIOS is broken or (b) I should remove the driver.
> Either way I would want to know.
Ok I'll do
> printk (KERN_WARNING "mtrr: your CPUs had inconsistent fixed MTRR
> printk (KERN_WARNING "mtrr: your CPUs had inconsistent variable MTRR
> printk (KERN_WARNING "mtrr: your CPUs had inconsistent MTRRdefType
> printk (KERN_WARNING "mtrr: probably your BIOS does not setup all
>
> These can actually be KERN_INFO, because it is not a problem and the
> mtrr driver fixes the issue.
I'd rather not overdo my patch. Better leave some KERN_WARNINGs where they
are now than hide something important. I am concentrated on killing
_obviously_ informative msgs.
> There are a _lot_ of printk statements in your patch where you didn't
> add a loglevel. You modified them for some reason (in many cases to
> change printk("%s" ...) to printk(pf: ...). You can easily find them
> via a search on `printk("' ... that same search can be a grep to find
> on-specified printks in the whole tree, too :)
I modified printks which were hard to find due to lack of
any greppable [ :-) ] string. Next poor soul will be more lucky :-)
I don't think adding log levels massively is good: I'd like to see
real world bogus warning log files and fix only those ('don't overdo it'
policy)
-- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Nov 15 2001 - 21:00:23 EST