if (a & X || b & ~Y) in dasd.c

From: Pete Zaitcev (zaitcev@redhat.com)
Date: Thu Nov 08 2001 - 15:57:49 EST

Carsten and others:

this code in 2.2.14 looks suspicious to me:

./drivers/s390/block/dasd.c:
        /* first of all lets try to find out the appropriate era_action */
        if (stat->flag & DEVSTAT_FLAG_SENSE_AVAIL ||
            stat->dstat & ~(DEV_STAT_CHN_END | DEV_STAT_DEV_END)) {
                /* anything abnormal ? */
                if (device->discipline->examine_error == NULL ||
                    stat->flag & DEVSTAT_HALT_FUNCTION) {
                        era = dasd_era_fatal;
                } else {
                        era = device->discipline->examine_error (cqr, stat);
                }
                DASD_DRIVER_DEBUG_EVENT (1, dasd_int_handler," era_code %d",
                                         era);
        }

Are you sure any parenthesises are not needed here?

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Nov 15 2001 - 21:00:19 EST