Re: [RFC][PATCH] extended attributes

From: Nathan Scott (nathans@sgi.com)
Date: Tue Nov 06 2001 - 22:19:56 EST


hello again Andi,

On Wed, Nov 07, 2001 at 02:32:18AM +0100, Andi Kleen wrote:
> I think it would be better to have a statefull readdir instead.
> The kernel supports it via the ->private_data field of struct file
> (not through fork,but that looks like a generic vfs bug)
>
> EA_FIRST_ENTRY to reset the fd the first entry, EA_READ_ENTRY to
> read the next one.

I'm not sure this would work for the extattr/lextattr variants where
we don't have an fd to hold the state. Should the list operation
be restricted to the fextattr variant, perhaps? I'm not sure about
all the implications of that, will have to see what everyone else
thinks I guess.

eg. the opening of the file before allowing a list operation could
have implications for XFSs DMAPI support (open might recall data from
tape), where the management tools need to be able to list these DMAPI
related attributes without affecting the backing storage, I believe -
I'll have to ask some DMAPI gurus about that one though.

Thanks for the input.

cheers.

-- 
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Nov 07 2001 - 21:00:33 EST