Re: [linux-usb-devel] RE: [PATCH -R] Re: 2.4.10 is toxic to my system when I use my US

From: Georg Acher (acher@in.tum.de)
Date: Thu Sep 27 2001 - 07:13:44 EST

Next message: Roeland Th. Jansen: "Re: Linux-2.4.10"
Previous message: Jan Kara: "Re: Linux-2.4.10 + ext3"
In reply to: Nemosoft Unv.: "RE: [PATCH -R] Re: 2.4.10 is toxic to my system when I use my US"
Next in thread: Enver Haase: "Re: 2.4.10 is toxic to my system when I use my USB webcam (was: More info. on crash)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Sep 27, 2001 at 08:33:27AM +0200, Nemosoft Unv. wrote:
> Personally, I say the above piece of code is faulty. Refering to a
> pointer after you appearently deleted it, is just very bad programming
> practice.

ACK ;-) And according to our CVS it is lurking around since March 2000.
There are a few similar actions in other portions of the code, but they are
correct (as far I can see...).

> I?d say, fix the usb-uhci file, and do a quick run on all other instances
> of list_del. I think most programmers got it right, or 2.4.10 kernels would
> be coming down all over the planet.

Fix attached. Please apply it.

-- Georg Acher, acher@in.tum.de http://www.in.tum.de/~acher/ "Oh no, not again !" The bowl of petunias

text/plain attachment: usb-uhci.patch

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Roeland Th. Jansen: "Re: Linux-2.4.10"
Previous message: Jan Kara: "Re: Linux-2.4.10 + ext3"
In reply to: Nemosoft Unv.: "RE: [PATCH -R] Re: 2.4.10 is toxic to my system when I use my US"
Next in thread: Enver Haase: "Re: 2.4.10 is toxic to my system when I use my USB webcam (was: More info. on crash)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Sep 30 2001 - 21:00:55 EST