Bug in tcp_v4_hnd_req?

From: Ulrich Weigand (Ulrich.Weigand@de.ibm.com)
Date: Wed Sep 26 2001 - 18:27:33 EST

Hello,

the following code in tcp_v4_hnd_req looks broken:

     if (nsk) {
          if (nsk->state != TCP_TIME_WAIT) {
               bh_lock_sock(nsk);
               return nsk;
          }
          tcp_tw_put((struct tcp_tw_bucket*)sk);
          return NULL;
     }

Shouldn't it put *nsk* instead of sk? This appears to be the cause of
weird crashes under heavy network load we've been experiencing ...

Mit freundlichen Gruessen / Best Regards

Ulrich Weigand 

--
  Dr. Ulrich Weigand
  Linux for S/390 Design & Development
  IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
  Phone: +49-7031/16-3727   ---   Email: Ulrich.Weigand@de.ibm.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Sep 30 2001 - 21:00:52 EST