On Wed, 26 Sep 2001, Andrea Arcangeli wrote:
<snip>
> > Andrea,
> >
> > This is going to make __GFP_NOFS allocations call writepage(): deadlock.
>
> (side note: I assume you mean GFP_NOFS)
>
> GFP_NOFS will never call writepage with the above change, obviously
> because __GFP_FS isn't set. So it can't deadlock.
if ((gfp_mask & __GFP_FS) && ((gfp_mask & __GFP_HIGHIO) || !PageHighMem(page)) && writepage) {
^^ ^^^^^ ^^^^ ^^^^^
If the page is not highmem, we are going to write the page. (independantly
of any GFP flag)
I'm I over looking something ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Sep 30 2001 - 21:00:51 EST