Andreas Schwab <schwab@suse.de> said:
> Andi Kleen <ak@suse.de> writes:
> |> +#define likely(x) __builtin_expect((x), !0)
>
> IMHO, this should better be written as
>
> #define likely(x) __builtin_expect(!!(x), 1)
>
> because x is not required to be pure boolean, so any nonzero value of x is
> as likely as 1.
I don't think you are really thinking "likely", you are thinking "must_be"
-- Horst von Brand vonbrand@sleipnir.valparaiso.cl Casilla 9G, Vin~a del Mar, Chile +56 32 672616 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:27 EST