[PATCH] inode.c cleanup

From: Alexander Viro (viro@math.psu.edu)
Date: Fri Sep 14 2001 - 13:27:04 EST


        Obvious cleanup: superblocks leave the list before they
can get ->s_dev equal to 0 and they do it under sb_lock, so test
in the chunk below is bogus.

        Please apply (it goes both for Linus' tree and -ac).

diff -urN S10-pre9/fs/inode.c S10-pre9-inode/fs/inode.c
--- S10-pre9/fs/inode.c Fri Sep 14 12:58:45 2001
+++ S10-pre9-inode/fs/inode.c Fri Sep 14 14:00:38 2001
@@ -405,8 +405,6 @@
         spin_lock(&sb_lock);
         sb = sb_entry(super_blocks.next);
         for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.next)) {
- if (!sb->s_dev)
- continue;
                 spin_unlock(&sb_lock);
                 if (!try_to_sync_unused_list(&sb->s_dirty))
                         return;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 15 2001 - 21:00:48 EST