Re: [PATCH] cleanup in fs/super.c (do_kern_mount())

From: Andries.Brouwer@cwi.nl
Date: Mon Sep 03 2001 - 12:07:28 EST


>>> +#define MS_NOUSER (1<<31)

>> a pity to waste a bit

> No, it's not useful for userland ;-) For internal use.

Hmm. Bad style, but acceptable if you never do it again :-)

[I mean: as soon as we start using more than 16 mount flags
we have the top 16 bits, but only 2^16 - 1 values are available
since 0xc0ed is a conventional value; now if the bits are
completely independent then it is strange to forbid one
particular random combination, and it is cleaner to use
only 15 bits with 2^15 values. If the top bit is never used
from user space then it is available for internal purposes.]

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Sep 07 2001 - 21:00:19 EST